-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added type annotation to the data_analysis_tools #63
Conversation
There re two problems: Solcore has so few annotations that it will inevitably fail any attempt to go through Besides, even if that is done, neither
Still, this will not solve the first problem, which requires Solcore to be properly annotated. Please, feel free to add this Let me know when you are done clicking on Many thanks for dealing with this! |
added the mypy, where is it request review? |
Top right of this PR screen, where it says "Reviwers". Anyway, I'm having a look at it, now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change when annotating parameters that can take the value None
.
Issue: #55
Output test:
`mypy ellipsometry_analysis.py
ellipsometry_analysis.py:1: error: No library stub file for module 'numpy'
ellipsometry_analysis.py:1: note: (Stub files are from https://github.com/python/typeshed)
ellipsometry_analysis.py:2: error: No library stub file for module 'matplotlib.pyplot'
ellipsometry_analysis.py:2: error: No library stub file for module 'matplotlib'
ellipsometry_analysis.py:4: error: Cannot find module named 'solcore.absorption_calculator'
ellipsometry_analysis.py:4: note: See https://mypy.readthedocs.io/en/latest/running_mypy.html#missing-imports
ellipsometry_analysis.py:5: error: No library stub file for module 'scipy.optimize'
ellipsometry_analysis.py:391: error: Cannot find module named 'solcore.absorption_calculator.dielectric_constant_models'
Found 6 errors in 1 file (checked 1 source file)
`
all the errors don't depend on the typing added